Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove some useless code in the binding package #49250

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 7, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: remove some useless code in the binding package

What changed and how does it work?

planner: remove some useless code in the binding package

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2023
Copy link

tiprow bot commented Dec 7, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #49250 (7489669) into master (be62f75) will increase coverage by 1.0225%.
The diff coverage is 52.1739%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49250        +/-   ##
================================================
+ Coverage   71.0499%   72.0725%   +1.0225%     
================================================
  Files          1368       1406        +38     
  Lines        402241     413120     +10879     
================================================
+ Hits         285792     297746     +11954     
- Misses        96570      96588        +18     
+ Partials      19879      18786      -1093     
Flag Coverage Δ
integration 43.6854% <52.1739%> (?)
unit 71.0521% <ø> (+0.0021%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.2512% <ø> (-4.6804%) ⬇️

Copy link

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 7, 2023

@EmmyMiao87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

}
defer func() {
if err == nil { // only recycle when no error
h.sPool.Put(resource)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this block h.sPool.Get() when there are a lot of errors?

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
Copy link

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 07:14:25.447769546 +0000 UTC m=+1684494.112995742: ☑️ agreed by hawkingrei.
  • 2023-12-07 08:16:52.336932622 +0000 UTC m=+1688241.002158818: ☑️ agreed by AilinKid.

Copy link

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, EmmyMiao87, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6f72f88 into pingcap:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants