Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: fix bug that watch loop will refresh frequently when channel closed (#49275) #49286

Merged
merged 7 commits into from
Dec 11, 2023
Merged

plugin: fix bug that watch loop will refresh frequently when channel closed (#49275) #49286

merged 7 commits into from
Dec 11, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49275

What problem does this PR solve?

Issue Number: close #49273

What changed and how does it work?

Recreate watch channel when it is closed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix bug that watch loop will refresh frequently when channel closed sometimes

@lcwangchao @ti-chi-bot
This is an automated cherry-pick of pingcap#49275
cf8fb28 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Dec 8, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 8, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 8, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 8, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-08 09:13:17.120882956 +0000 UTC m=+1888.158109884: ☑️ agreed by lcwangchao.
  • 2023-12-08 09:16:10.650278213 +0000 UTC m=+2061.687505141: ☑️ agreed by CbcWestwolf.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

3 similar comments
@lcwangchao
Copy link
Collaborator

/retest

@hawkingrei
Copy link
Member

/retest

@lcwangchao
Copy link
Collaborator

/retest

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tiprow tiprow
Copy link

tiprow bot commented Dec 11, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 721bb1a into pingcap:release-5.4 Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees

@lcwangchao lcwangchao

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @hawkingrei @lcwangchao @CbcWestwolf