-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: fix data race in runaway DeriveChecker #49354
Conversation
Hi @glorv. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49354 +/- ##
================================================
+ Coverage 71.0537% 71.8421% +0.7883%
================================================
Files 1368 1411 +43
Lines 401803 414527 +12724
================================================
+ Hits 285496 297805 +12309
- Misses 96449 97913 +1464
+ Partials 19858 18809 -1049
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -191,7 +192,7 @@ type RunawayManager struct { | |||
// activeGroup is used to manage the active runaway watches of resource group | |||
activeGroup map[string]int64 | |||
activeLock sync.RWMutex | |||
metricsMap map[string]prometheus.Counter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to run make bazel_prepare
.
[LGTM Timeline notifier]Timeline:
|
98ece2d
to
95d9c0a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CabinfeverB, hawkingrei, lance6716, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #49351
Problem Summary:
What changed and how does it work?
Change map to SyncMap to avoid data race.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.