Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global sort: global sort whole process in ut #49419

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Dec 13, 2023

What problem does this PR solve?

Issue Number: ref #48952

Problem Summary:

What changed and how does it work?

  1. Test global sort locally with read&write step and read&Sort step.
  2. Test global sort locally with read&write step, merge step and read&Sort step.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2023
Copy link

tiprow bot commented Dec 13, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy ywqzzy changed the title global sort: global sort whole process in ut [WIP] global sort: global sort whole process in ut Dec 13, 2023
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #49419 (db6819b) into master (5519033) will increase coverage by 0.5962%.
Report is 2 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49419        +/-   ##
================================================
+ Coverage   70.9870%   71.5833%   +0.5962%     
================================================
  Files          1368       1417        +49     
  Lines        399791     415447     +15656     
================================================
+ Hits         283800     297391     +13591     
- Misses        96179      99257      +3078     
+ Partials      19812      18799      -1013     
Flag Coverage Δ
integration 43.7834% <0.0000%> (?)
unit 70.9870% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.8250% <0.0000%> (-5.0599%) ⬇️

@ywqzzy ywqzzy changed the title [WIP] global sort: global sort whole process in ut global sort: global sort whole process in ut Dec 14, 2023
@ti-chi-bot ti-chi-bot bot removed do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Dec 14, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 14, 2023
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 14, 2023
Copy link

ti-chi-bot bot commented Dec 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 03:10:55.568723017 +0000 UTC m=+498546.605949944: ☑️ agreed by D3Hunter.
  • 2023-12-14 03:22:19.311908288 +0000 UTC m=+499230.349135231: ☑️ agreed by Benjamin2037.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Dec 14, 2023

/build

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Dec 14, 2023

/retest

Copy link

tiprow bot commented Dec 14, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit d076bc1 into pingcap:master Dec 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants