Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: use PD HTTP client #49599

Merged
merged 5 commits into from
Dec 21, 2023
Merged

lightning: use PD HTTP client #49599

merged 5 commits into from
Dec 21, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 20, 2023

What problem does this PR solve?

Issue Number: ref #48740

Problem Summary:

What changed and how does it work?

lightning local backend switch from pdController to tikv/pd#7300

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

    pass existing tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
Copy link

tiprow bot commented Dec 20, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #49599 (5431750) into master (d84df2b) will increase coverage by 0.5229%.
Report is 14 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49599        +/-   ##
================================================
+ Coverage   71.0024%   71.5253%   +0.5229%     
================================================
  Files          1368       1423        +55     
  Lines        399178     420880     +21702     
================================================
+ Hits         283426     301036     +17610     
- Misses        95967     100984      +5017     
+ Partials      19785      18860       -925     
Flag Coverage Δ
integration 43.6648% <0.0000%> (?)
unit 71.0083% <ø> (+0.0059%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2680% <0.0000%> (-5.6142%) ⬇️

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 02:50:33.490449694 +0000 UTC m=+1102124.527676621: ☑️ agreed by hawkingrei.
  • 2023-12-21 02:58:07.24423821 +0000 UTC m=+1102578.281465136: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 21, 2023
br/pkg/pdutil/pd.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, hawkingrei, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit e4489f7 into pingcap:master Dec 21, 2023
17 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49646.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52126.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 27, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants