Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: update IgnoreErrorCheckpoint() for G201/G202 security rules #49637

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 20, 2023

What problem does this PR solve?

Issue Number: ref #30699

Problem Summary:

What changed and how does it work?

This PR removes // nolint:gosec for IgnoreErrorCheckpoint() as a tiny security enhancement of our source code, see https://securego.io/docs/rules/g201-g202.html for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #49637 (b026485) into master (6a5a5e7) will increase coverage by 0.4595%.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49637        +/-   ##
================================================
+ Coverage   70.9795%   71.4391%   +0.4595%     
================================================
  Files          1368       1423        +55     
  Lines        398698     415894     +17196     
================================================
+ Hits         282994     297111     +14117     
- Misses        95933      99989      +4056     
+ Partials      19771      18794       -977     
Flag Coverage Δ
integration 43.6644% <0.0000%> (?)
unit 70.9792% <ø> (-0.0003%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3482% <0.0000%> (-5.5344%) ⬇️

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
@lance6716
Copy link
Contributor

/test pull-lightning-integration-test

Copy link

tiprow bot commented Dec 21, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 01:51:06.512603098 +0000 UTC m=+1098557.549830022: ☑️ agreed by lance6716.
  • 2023-12-21 02:04:16.662187013 +0000 UTC m=+1099347.699413940: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 56bf775 into pingcap:master Dec 21, 2023
30 of 39 checks passed
@bb7133 bb7133 deleted the bb7133/en_gosec branch December 21, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants