-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: do not use fmt.Sprint to format SQL (#49620) #49649
domain: do not use fmt.Sprint to format SQL (#49620) #49649
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #49649 +/- ##
================================================
Coverage ? 71.9752%
================================================
Files ? 1401
Lines ? 406744
Branches ? 0
================================================
Hits ? 292755
Misses ? 94285
Partials ? 19704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hi-rustin, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #49620
What problem does this PR solve?
Issue Number: close #49619
Problem Summary:
What changed and how does it work?
https://github.com/pingcap/tidb/blob/master/pkg/domain/plan_replayer.go#L169
We use fmt.Sprintf here. But this would generate an invalid SQL if the user's SQL contains a
'
.So I added a test case to cover it and also fixed it by using the
%?
syntax.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.