-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix index merge reader may lost enforced prop sort when table plan is pure #49844
planner: fix index merge reader may lost enforced prop sort when table plan is pure #49844
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49844 +/- ##
================================================
+ Coverage 70.9584% 71.1571% +0.1987%
================================================
Files 1368 1430 +62
Lines 397089 424992 +27903
================================================
+ Hits 281768 302412 +20644
- Misses 95623 103576 +7953
+ Partials 19698 19004 -694
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -100,7 +100,7 @@ type copTask struct { | |||
} | |||
|
|||
func (t *copTask) invalid() bool { | |||
return t.tablePlan == nil && t.indexPlan == nil | |||
return t.tablePlan == nil && t.indexPlan == nil && len(t.idxMergePartPlans) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, what is the table plan means ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly, table plan means subplan including TableRowIDScan or Selection/Aggregation on top of that TableRowIDScan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid a case that doesn't have tablePlan and indexPlan, but indexMergePartPlans, current this case won't happen after I dig the code from convertToIndexMergeScan.
adding this is just to make the guard line(won't affect any test case before)
Signed-off-by: AilinKid <314806019@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #49605
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.