-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support hints in 'REPLACE INTO' statement #50007
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50007 +/- ##
================================================
- Coverage 71.9115% 68.5366% -3.3750%
================================================
Files 1438 1441 +3
Lines 345747 412686 +66939
================================================
+ Hits 248632 282841 +34209
- Misses 76855 110843 +33988
+ Partials 20260 19002 -1258
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, hawkingrei, tangenta, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-cherry-pick |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #34325
Problem Summary:
Hints are not supported in
REPLACE INTO ...
statement.What changed and how does it work?
I simply modify the parser to support this hints. I also tested that some simple hints (e.g.
SET_VAR
) actually work.Check List
Tests
Side effects
Documentation
Release note