Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: use EncodeKey to encode groupkey in StreamAggExec (#49974) #50024

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49974

What problem does this PR solve?

Issue Number: close #49902

Problem Summary:

What changed and how does it work?

Use EncodeKey function to encode the groupkey within StreamAggExec. This approach is necessary as it considers collation when aggregating the result.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed the issue with StreamAgg that caused incorrect results due to mishandling collation ci.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
@wshwsh12 wshwsh12 force-pushed the cherry-pick-49974-to-release-6.5 branch from e31e15c to 65cf090 Compare January 8, 2024 08:17
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2024
Copy link

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2024
Copy link

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 08:31:38.397314364 +0000 UTC m=+259287.981568053: ☑️ agreed by XuHuaiyu.
  • 2024-01-08 09:04:05.877029478 +0000 UTC m=+261235.461283150: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 8, 2024
@wshwsh12
Copy link
Contributor

wshwsh12 commented Jan 8, 2024

/retest

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@cd073ea). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #50024   +/-   ##
================================================
  Coverage               ?   73.6873%           
================================================
  Files                  ?       1090           
  Lines                  ?     349930           
  Branches               ?          0           
================================================
  Hits                   ?     257854           
  Misses                 ?      75521           
  Partials               ?      16555           

@ti-chi-bot ti-chi-bot bot merged commit 6a5b2a3 into pingcap:release-6.5 Jan 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants