Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix select wrong partition for hash partition table #50045

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jan 3, 2024

What problem does this PR solve?

Issue Number: close #50044, close #49842

Problem Summary: Caused by #49853, I made a mistake about mathutil.Abs and select a wrong partiton for hash partition table.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
Copy link

tiprow bot commented Jan 3, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Merging #50045 (812c285) into master (965ad8a) will decrease coverage by 3.4242%.
Report is 23 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50045        +/-   ##
================================================
- Coverage   71.9829%   68.5587%   -3.4242%     
================================================
  Files          1438       1441         +3     
  Lines        345739     412118     +66379     
================================================
+ Hits         248873     282543     +33670     
- Misses        76650     110505     +33855     
+ Partials      20216      19070      -1146     
Flag Coverage Δ
integration 43.8522% <100.0000%> (?)
unit 71.9827% <ø> (-0.0002%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.3129% <ø> (ø)
parser ∅ <ø> (∅)
br 42.9185% <ø> (-8.7358%) ⬇️

@Defined2014
Copy link
Contributor Author

/test check-dev

Copy link

tiprow bot commented Jan 4, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
@Defined2014 Defined2014 requested a review from xhebox January 4, 2024 02:55
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
Copy link

ti-chi-bot bot commented Jan 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 02:55:10.958037351 +0000 UTC m=+2312001.995264276: ☑️ agreed by tiancaiamao.
  • 2024-01-04 04:35:02.321337359 +0000 UTC m=+2317993.358564306: ☑️ agreed by bb7133.

@Defined2014
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Jan 4, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit ebe334f into master Jan 4, 2024
@ti-chi-bot ti-chi-bot bot deleted the fix-50044 branch January 4, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants