Lightning: increase backoff if split fails (#49518) #50164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
ok-to-test
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/M
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
added
size/S
|
/cherry-pick-invite |
|
@okJiang you're already a collaborator in repo |
okJiang
approved these changes
Jan 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #50164 +/- ##
================================================
Coverage ? 73.6423%
================================================
Files ? 1094
Lines ? 350611
Branches ? 0
================================================
Hits ? 258198
Misses ? 75840
Partials ? 16573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #49518
What problem does this PR solve?
Issue Number: close #49517
Problem Summary:
Lightning job is failing intermittently after enable BR on prod clusters because of batch split failure. During the backup process, BR temporarily disables the schedulers for a period of 1-2 minutes. However, the Lightning job, which does not have a backoff mechanism, continues to retry the process for up to 5 times without pausing or spacing out the retries.
What changed and how does it work?
i am adding a exponential back off before each retry and now it will retry upto 930 seconds before if fails the job
Check List
Tests
Side effects
NO
Documentation
NO
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.