Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade to rules_go 0.44.2 #50228

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 9, 2024

What problem does this PR solve?

Issue Number: close #50216

Problem Summary:

Upgrade rules_go can solve some DATA RACE in test.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #50228 (7150368) into master (75aa3c7) will decrease coverage by 14.4505%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50228         +/-   ##
=================================================
- Coverage   70.0593%   55.6088%   -14.4505%     
=================================================
  Files          1440       1553        +113     
  Lines        419536     588446     +168910     
=================================================
+ Hits         293924     327228      +33304     
- Misses       105300     238595     +133295     
- Partials      20312      22623       +2311     
Flag Coverage Δ
integration 36.8798% <ø> (?)
unit 70.2113% <ø> (+0.1520%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.9717% <ø> (+6.2675%) ⬆️

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 09:00:34.762389948 +0000 UTC m=+347424.346643633: ☑️ agreed by hawkingrei.
  • 2024-01-10 03:04:05.46555953 +0000 UTC m=+412435.049813212: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 868e177 into pingcap:master Jan 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the rules_go/go/tools/bzltestutil
3 participants