Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: new snapshot tagging #50548

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jan 18, 2024

What problem does this PR solve?

Issue Number: close #50559

Problem Summary:

What changed and how does it work?

  1. Add the new tag to snapshots
  2. Check fsr enablement periodically instead of sleep for a long time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
Copy link

tiprow bot commented Jan 18, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #50548 (da6a98b) into master (549a5d9) will decrease coverage by 14.6838%.
Report is 7 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50548         +/-   ##
=================================================
- Coverage   70.2609%   55.5772%   -14.6838%     
=================================================
  Files          1452       1563        +111     
  Lines        420451     587951     +167500     
=================================================
+ Hits         295413     326767      +31354     
- Misses       104700     238381     +133681     
- Partials      20338      22803       +2465     
Flag Coverage Δ
integration 36.7320% <0.0000%> (?)
unit 70.2107% <0.0000%> (-0.0503%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5578% <0.0000%> (+6.0704%) ⬆️

@BornChanger BornChanger changed the title New snapshot tagging ebs br: new snapshot tagging Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Jan 18, 2024
@BornChanger
Copy link
Contributor Author

/cc @YuJuncen @WangLe1321 @3pointer

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 18, 2024
@BornChanger
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 18, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 10:53:35.071627119 +0000 UTC m=+439656.635924825: ☑️ agreed by 3pointer.
  • 2024-01-18 12:47:28.85461436 +0000 UTC m=+446490.418912066: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 7ba2330 into pingcap:master Jan 18, 2024
32 of 36 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50569.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #50570.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50571.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 18, 2024
br/pkg/aws/ebs.go Show resolved Hide resolved
@@ -73,6 +73,10 @@ func (e *EC2Session) CreateSnapshots(backupInfo *config.EBSBasedBRMeta) (map[str
}
}

tags := []*ec2.Tag{
ec2Tag("TiDBCluster-BR", "new"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ti-chi-bot bot pushed a commit that referenced this pull request Feb 21, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 23, 2024
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
)

close pingcap#50559

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: add tag TiDBCluster-BR to snapshots
5 participants