Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: remove revert subtask #50550

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50549

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 18, 2024
Copy link

tiprow bot commented Jan 18, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #50550 (770bb5e) into master (8bb4d2f) will decrease coverage by 14.1758%.
Report is 6 commits behind head on master.
The diff coverage is 65.2173%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50550         +/-   ##
=================================================
- Coverage   70.2648%   56.0891%   -14.1758%     
=================================================
  Files          1454       1566        +112     
  Lines        420570     592790     +172220     
=================================================
+ Hits         295513     332491      +36978     
- Misses       104729     237364     +132635     
- Partials      20328      22935       +2607     
Flag Coverage Δ
integration 36.6480% <50.0000%> (?)
tiprow_ft ?
unit 70.8350% <65.2173%> (+0.5728%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 57.0254% <ø> (+6.5250%) ⬆️

pkg/disttask/framework/storage/task_state.go Outdated Show resolved Hide resolved
state = proto.SubtaskStateRevertPending
}
InsertSubtask(t, gm, taskID, step, execID, meta, state, tp, concurrency)
func CreateSubTask(t *testing.T, gm *storage.TaskManager, taskID int64, step proto.Step, execID string, meta []byte, tp proto.TaskType, concurrency int) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is useless now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a wrapper to create pending subtask

pkg/disttask/framework/proto/task.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2024
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/disttask/framework/storage/table_test.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2024
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 02:52:20.486759976 +0000 UTC m=+756382.051057675: ☑️ agreed by ywqzzy.
  • 2024-01-22 09:52:45.41381449 +0000 UTC m=+781606.978112194: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit d1e6f1c into pingcap:master Jan 22, 2024
22 checks passed
@D3Hunter D3Hunter deleted the remove-revert-st branch January 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disttask: remove reverting subtask
3 participants