-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta/autoid: make autoid client ResetConn operation concurrency-safe (#50522) #50594
meta/autoid: make autoid client ResetConn operation concurrency-safe (#50522) #50594
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5-20231214-v7.5.0 #50594 +/- ##
================================================================
Coverage ? 71.9356%
================================================================
Files ? 1398
Lines ? 406337
Branches ? 0
================================================================
Hits ? 292301
Misses ? 94366
Partials ? 19670
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test build |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
@hawkingrei: No presubmit jobs available for pingcap/tidb@release-7.5-20231214-v7.5.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test build |
@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5-20231214-v7.5.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bb7133 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b856499
into
pingcap:release-7.5-20231214-v7.5.0
What problem does this PR solve?
Issue Number: close #50519
Problem Summary:
What changed and how does it work?
Cherry-pick #50522 for a hotfix
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.