-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: merge range in lightweight when snapshot restore #50648
br: merge range in lightweight when snapshot restore #50648
Conversation
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50648 +/- ##
================================================
- Coverage 72.1179% 70.8612% -1.2567%
================================================
Files 1454 1463 +9
Lines 347571 437040 +89469
================================================
+ Hits 250661 309692 +59031
- Misses 76542 106543 +30001
- Partials 20368 20805 +437
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -74,6 +76,47 @@ func (rg *Range) Less(than btree.Item) bool { | |||
return bytes.Compare(rg.StartKey, ta.StartKey) < 0 | |||
} | |||
|
|||
// NeedsMerge checks whether two ranges needs to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly move from br/pkg/restore/merge.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/type cherry-pick-for-release-7.5 |
/type cherry-pick-for-release-6.5 |
/type cherry-pick-for-release-7.1 |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #50613
Problem Summary:
Merge file ranges takes too much time when the file ranges's size is much large.
What changed and how does it work?
use the O(n) algorithm
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.