Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix update process info will data race with expensive-query check #50696

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50607

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2024
Copy link

tiprow bot commented Jan 24, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid AilinKid changed the title planner: fix update process info will data race with expensivequery check planner: fix update process info will data race with expensive-query check Jan 24, 2024
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid changed the title planner: fix update process info will data race with expensive-query check session: fix update process info will data race with expensive-query check Jan 24, 2024
@AilinKid
Copy link
Contributor Author

/check-issue-triage-complete

1 similar comment
@AilinKid
Copy link
Contributor Author

/check-issue-triage-complete

@AilinKid
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 24, 2024
@AilinKid
Copy link
Contributor Author

/check-required-labels

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #50696 (8fb2e23) into master (c936265) will decrease coverage by 14.3731%.
Report is 12 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50696         +/-   ##
=================================================
- Coverage   70.3332%   55.9602%   -14.3731%     
=================================================
  Files          1456       1567        +111     
  Lines        420707     591034     +170327     
=================================================
+ Hits         295897     330744      +34847     
- Misses       104467     237398     +132931     
- Partials      20343      22892       +2549     
Flag Coverage Δ
integration 37.0079% <100.0000%> (?)
unit 70.5465% <100.0000%> (+0.2309%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.9351% <ø> (+6.4231%) ⬆️

Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 08:12:40.737174096 +0000 UTC m=+948402.301471801: ☑️ agreed by hawkingrei.
  • 2024-01-25 03:13:58.336798134 +0000 UTC m=+1016879.901095824: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit cf320b2 into pingcap:master Jan 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the ProcessInfo
3 participants