-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix CTE goroutine leak when exceeds mem quota #50828
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50828 +/- ##
================================================
+ Coverage 72.2960% 72.8127% +0.5167%
================================================
Files 1467 1469 +2
Lines 361760 442752 +80992
================================================
+ Hits 261538 322380 +60842
- Misses 80904 100235 +19331
- Partials 19318 20137 +819
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…cap#50828)" This reverts commit fa340f3.
What problem does this PR solve?
Issue Number: close #50337
Problem Summary:
seedExec.Open()
return succ andrecursiveExec.Open()
returns error, and if this cte is shared by multiple operators, other operator may openseedExec
again, which cause resource leaking.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.