Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stmtsummary: add request-units info in statements_summary (#49504) #50880

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49504

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Add following 7 columns in information_schema.statements_summary:

  `MAX_REQUEST_UNIT_READ` double unsigned NOT NULL COMMENT 'Max read request-unit cost of these statements',
  `AVG_REQUEST_UNIT_READ` double unsigned NOT NULL COMMENT 'Average read request-unit cost of these statements',
  `MAX_REQUEST_UNIT_WRITE` double unsigned NOT NULL COMMENT 'Max write request-unit cost of these statements',
  `AVG_REQUEST_UNIT_WRITE` double unsigned NOT NULL COMMENT 'Average write request-unit cost of these statements',
  `MAX_QUEUED_RC_TIME` bigint(22) unsigned NOT NULL COMMENT 'Max time of waiting for available request-units',
  `AVG_QUEUED_RC_TIME` bigint(22) unsigned NOT NULL COMMENT 'Max time of waiting for available request-units',
  `RESOURCE_GROUP` varchar(64) DEFAULT NULL COMMENT 'Bind resource group name'

And add resource_group_name in statements_summary's aggration key, so after this change, the same sql executed by under different resource groups with be collected as different record.

Result example:

mysql> select DIGEST_TEXT, MAX_REQUEST_UNIT_READ, AVG_REQUEST_UNIT_READ, MAX_REQUEST_UNIT_WRITE, AVG_REQUEST_UNIT_WRITE, MAX_QUEUED_RC_TIME, AVG_QUEUED_RC_TIME, RESOURCE_GROUP from statements_summary where AVG_REQUEST_UNIT_READ > 0 limit 1\G;
*************************** 1. row ***************************
           DIGEST_TEXT: select `c` from `sbtest1` where `id` = ?
 MAX_REQUEST_UNIT_READ: 0.7367986354166667
 AVG_REQUEST_UNIT_READ: 0.5131357532322988
MAX_REQUEST_UNIT_WRITE: 0
AVG_REQUEST_UNIT_WRITE: 0
    MAX_QUEUED_RC_TIME: 212279751
    AVG_QUEUED_RC_TIME: 35929510
        RESOURCE_GROUP: rg1
1 row in set (0.02 sec)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 1, 2024
Copy link

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wjhuang2016 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 1, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 9, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 f35285b link true /test check-dev2
idc-jenkins-ci-tidb/build f35285b link true /test build
idc-jenkins-ci-tidb/check_dev f35285b link true /test check-dev
idc-jenkins-ci-tidb/mysql-test f35285b link true /test mysql-test
idc-jenkins-ci-tidb/unit-test f35285b link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nolouch nolouch closed this Feb 19, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants