Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec: encode checksum for timestamp consider tz #50896

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 1, 2024

What problem does this PR solve?

Issue Number: close #50851

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix row checksum calculation on the timestamp does not consider time zone cause the CDC failed to verify the checksum

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
Copy link

tiprow bot commented Feb 1, 2024

Hi @3AceShowHand. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #50896 (c15d175) into master (ff8b3d3) will increase coverage by 4.0050%.
Report is 1 commits behind head on master.
The diff coverage is 85.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50896        +/-   ##
================================================
+ Coverage   70.5000%   74.5050%   +4.0050%     
================================================
  Files          1466       1462         -4     
  Lines        434007     421719     -12288     
================================================
+ Hits         305975     314202      +8227     
+ Misses       108758      87725     -21033     
- Partials      19274      19792       +518     
Flag Coverage Δ
integration 48.9980% <0.0000%> (?)
tiprow_ft ?
unit 70.2825% <85.0000%> (-0.0258%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-0.0852%) ⬇️
parser ∅ <ø> (∅)
br 56.5120% <ø> (+10.7775%) ⬆️

@qw4990
Copy link
Contributor

qw4990 commented Feb 1, 2024

/test all

Copy link

tiprow bot commented Feb 1, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/table/tables/tables.go Outdated Show resolved Hide resolved
pkg/util/rowcodec/common.go Outdated Show resolved Hide resolved
pkg/ddl/column.go Outdated Show resolved Hide resolved
@3AceShowHand 3AceShowHand changed the title codec: encode checksum for timestamp, consider tz. codec: encode checksum for timestamp consider tz. Feb 1, 2024
@3AceShowHand 3AceShowHand changed the title codec: encode checksum for timestamp consider tz. codec: encode checksum for timestamp consider tz Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
Copy link

ti-chi-bot bot commented Feb 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-01 10:31:07.083027822 +0000 UTC m=+1647908.647325515: ☑️ agreed by zyguan.
  • 2024-02-01 12:17:30.998729245 +0000 UTC m=+1654292.563026935: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Feb 1, 2024

@wjhuang2016 @tangenta
Please help take a look

Copy link

tiprow bot commented Feb 1, 2024

@3AceShowHand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test c935bc5 link true /test tiprow_fast_test
tidb_parser_test c935bc5 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 2, 2024

@3AceShowHand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ywqzzy, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8491da1 into pingcap:master Feb 2, 2024
21 checks passed
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.5: #50929.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.1: #50930.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

row level checksum calculation failed on timestamp value
6 participants