Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: handle tag limit exceed issue #50941

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Feb 3, 2024

What problem does this PR solve?

Issue Number: close #50942

Problem Summary:

What changed and how does it work?

Avoid recursively copy tagging from snapshots when creating volumes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2024
Copy link

tiprow bot commented Feb 3, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Merging #50941 (eb70f1d) into master (ba9b8a8) will decrease coverage by 15.3757%.
Report is 37 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50941         +/-   ##
=================================================
- Coverage   70.6340%   55.2583%   -15.3757%     
=================================================
  Files          1467       1577        +110     
  Lines        434748     611227     +176479     
=================================================
+ Hits         307080     337754      +30674     
- Misses       108476     250480     +142004     
- Partials      19192      22993       +3801     
Flag Coverage Δ
integration 37.5316% <0.0000%> (?)
unit 70.9852% <0.0000%> (+0.5484%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-0.0313%) ⬇️
parser ∅ <ø> (∅)
br 50.8244% <0.0000%> (+5.0143%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2024
@BornChanger
Copy link
Contributor Author

br/pkg/aws/ebs.go Outdated Show resolved Hide resolved
br/pkg/aws/ebs.go Outdated Show resolved Hide resolved
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 21, 2024

@WangLe1321: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, WangLe1321, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 07:48:12.719415622 +0000 UTC m=+516181.467038733: ☑️ agreed by YuJuncen.
  • 2024-02-22 07:52:11.546827824 +0000 UTC m=+516420.294450934: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit 20ffdd1 into pingcap:master Feb 22, 2024
33 of 35 checks passed
@BornChanger
Copy link
Contributor Author

/label needs-cherry-pick-release-6.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 22, 2024
@BornChanger
Copy link
Contributor Author

/label needs-cherry-pick-release-7.1

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 22, 2024
@BornChanger
Copy link
Contributor Author

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51250.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51251.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51252.

ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: EBS br failed due to tag limit exceeded
5 participants