Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: update TestDefaultColumnWithReplace error code #51115

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51114

Problem Summary:
Different UUID values will result in different error code.

tidb> create table t1 (c int(10), c1 int default (REPLACE(UPPER(UUID()), '-', '')));
Query OK, 0 rows affected (0.04 sec)

tidb> insert into t1(c) values (1),(2),(3);
ERROR 1690 (22003): BIGINT value is out of range in '451E9'
tidb> insert into t1(c) values (1),(2),(3);
ERROR 1292 (22007): Truncated incorrect DOUBLE value: '463ED8D2CE3911EE988E3C7D0A09BA5A'

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2024
Copy link

tiprow bot commented Feb 18, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala
Copy link
Contributor Author

/check-issue-triage-complete

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 08:46:34.280987396 +0000 UTC m=+174083.028610507: ☑️ agreed by bb7133.
  • 2024-02-18 08:48:26.471134792 +0000 UTC m=+174195.218757905: ☑️ agreed by hawkingrei.

@zimulala zimulala requested review from tangenta and removed request for lcwangchao February 18, 2024 08:53
Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Merging #51115 (7ba7e4e) into master (464a126) will increase coverage by 0.4817%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51115        +/-   ##
================================================
+ Coverage   72.3189%   72.8007%   +0.4817%     
================================================
  Files          1467       1467                
  Lines        361663     436233     +74570     
================================================
+ Hits         261551     317581     +56030     
- Misses        80822      98742     +17920     
- Partials      19290      19910       +620     
Flag Coverage Δ
integration 49.1544% <ø> (?)
unit 70.4081% <ø> (-1.7708%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.2860%) ⬇️
parser ∅ <ø> (∅)
br 51.7822% <ø> (+5.4585%) ⬆️

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit a465300 into pingcap:master Feb 18, 2024
23 checks passed
@zimulala zimulala deleted the zimuxia/replace-err branch February 19, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable test TestDefaultColumnWithReplace
4 participants