Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling: add min tls version config item #51127

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Feb 18, 2024

What problem does this PR solve?

Issue Number: ref #36036

Problem Summary:

What changed and how does it work?

  • dumpling may connect to old mysql server, which only support tlsv10, so we use an option to config it if config.MinTLSVersion is not 0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2024
Copy link

tiprow bot commented Feb 18, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Merging #51127 (84ff7cf) into master (464a126) will increase coverage by 0.2439%.
Report is 5 commits behind head on master.
The diff coverage is 76.9230%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51127        +/-   ##
================================================
+ Coverage   72.3189%   72.5629%   +0.2439%     
================================================
  Files          1467       1467                
  Lines        361663     435815     +74152     
================================================
+ Hits         261551     316240     +54689     
- Misses        80822      99634     +18812     
- Partials      19290      19941       +651     
Flag Coverage Δ
integration 49.0402% <0.0000%> (?)
unit 70.3115% <76.9230%> (-1.8674%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <50.0000%> (-2.3172%) ⬇️
parser ∅ <ø> (∅)
br 51.0669% <ø> (+4.7432%) ⬆️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Feb 18, 2024

/retest

Copy link

tiprow bot commented Feb 18, 2024

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 14:11:54.190940421 +0000 UTC m=+193602.938563530: ☑️ agreed by lance6716.
  • 2024-02-18 14:58:19.435169555 +0000 UTC m=+196388.182792663: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot removed the approved label Feb 19, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3ceeb3f into master Feb 19, 2024
25 of 26 checks passed
@ti-chi-bot ti-chi-bot bot deleted the addMinTLSVersionForDumpling branch February 19, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants