planner: fix ExtractCorrelatedCols method in PhysicalTableScan (cherry-pick #51205)

[Lloyd-Pottiger]

What problem does this PR solve?

Issue Number: close #51204

Problem Summary:

What changed and how does it work?

Before, we do not try to extract correlated column in LateMaterializationFilterCondition. So when the correlated columns only in LateMaterializationFilterCondition, exprs failed to fill in correlated column with constant value during Plan2Pb, and it leads to wrong query result.

Now, in ExtractCorrelatedCols method, we will also try to extract correlated column in LateMaterializationFilterCondition.

Also fix other methods.

Check List

Currently, integration test do not support TiFlash, so I will add tests in https://github.com/pingcap/tiflash later

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix wrong query result of Apply operator when there are correlated column in push down conditions

[tiprow]

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JaySon-Huang]

please update the "Problem Summary" and "Release note"

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@b31b3e5). Click here to learn what that means.
The diff coverage is 25.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #51208   +/-   ##
================================================
  Coverage               ?   71.9763%           
================================================
  Files                  ?       1404           
  Lines                  ?     408105           
  Branches               ?          0           
================================================
  Hits                   ?     293739           
  Misses                 ?      94615           
  Partials               ?      19751           

Flag	Coverage Δ
unit	71.9763% <25.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.2107% <0.0000%> (?)

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-21 01:18:15.374378587 +0000 UTC m=+406384.122001698: ☑️ agreed by windtalker.
• 2024-02-21 02:28:34.34076959 +0000 UTC m=+410603.088392701: ☑️ agreed by SeaRise.

[hawkingrei]

/hold

[hawkingrei]

You should merge #51205 first and add some tests for it.

[hawkingrei]

/unhold