-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: introduce a new fuzzy binding cache #51401
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51401 +/- ##
================================================
+ Coverage 70.6330% 73.2785% +2.6454%
================================================
Files 1461 1462 +1
Lines 434877 441256 +6379
================================================
+ Hits 307167 323346 +16179
+ Misses 108414 98062 -10352
- Partials 19296 19848 +552
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@qw4990: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@qw4990: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51347
Problem Summary: planner: introduce a new fuzzy binding cache
What changed and how does it work?
Mainly it's refactoring. Introduce a new cache between the BindingHandler and the BindingCache, where we can implement some advanced binding features like 'fuzzy matching', 'auto binding loading if cache miss', etc...
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.