Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: print callstack when exiting before preparing done (#51371) #51549

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51371

What problem does this PR solve?

Issue Number: close #51370

Problem Summary:
It is hard to debug what happens when the init pod get timed out.

What changed and how does it work?

This PR will print all gorouintes to stdout once the prepare-for-snapshot-backup command exits before finishing the full prepare stage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

When we are not yet finished:
CleanShot 2024-02-27 at 19 28 14@2x
When we have finished prepare stage:
CleanShot 2024-02-27 at 19 28 51@2x

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 6, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 6, 2024
@BornChanger
Copy link
Contributor

/retest

1 similar comment
@BornChanger
Copy link
Contributor

/retest

@nkg-
Copy link
Contributor

nkg- commented Mar 20, 2024

@BornChanger : Can you merge this please.

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2024
Copy link

ti-chi-bot bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 21, 2024
Copy link

ti-chi-bot bot commented Mar 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 11:06:40.269770688 +0000 UTC m=+251627.292017068: ☑️ agreed by BornChanger.
  • 2024-03-21 00:09:41.447605001 +0000 UTC m=+1508208.469851389: ☑️ agreed by YuJuncen.

@BornChanger
Copy link
Contributor

/retest

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@8cdacb7). Click here to learn what that means.
The diff coverage is 38.0952%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51549   +/-   ##
================================================
  Coverage               ?   73.6370%           
================================================
  Files                  ?       1095           
  Lines                  ?     350863           
  Branches               ?          0           
================================================
  Hits                   ?     258365           
  Misses                 ?      75889           
  Partials               ?      16609           

@ti-chi-bot ti-chi-bot bot merged commit ea8ec37 into pingcap:release-6.5 Mar 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants