Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, tests: make the error message of the default value expression more appropriate. #51704

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51703

Problem Summary:

What changed and how does it work?

Now we support REPLACE as the default value expression, but don't support REPLACE('xdfj-jfj', '-', '')).
So tiny update the error message.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
Copy link

tiprow bot commented Mar 12, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 12, 2024
@zimulala zimulala changed the title ddl, tests: tiny update the error message ddl, tests: make the error message of the default value expression more appropriate. Mar 12, 2024
Copy link

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2024
Copy link

ti-chi-bot bot commented Mar 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 09:01:54.42370435 +0000 UTC m=+762541.445950736: ☑️ agreed by hawkingrei.
  • 2024-03-12 09:11:26.680423813 +0000 UTC m=+763113.702670201: ☑️ agreed by ywqzzy.

Copy link

tiprow bot commented Mar 12, 2024

@zimulala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 12cfc4b link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #51704 (1de619d) into master (a1d5a5a) will increase coverage by 2.1270%.
Report is 2 commits behind head on master.
The diff coverage is 75.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51704        +/-   ##
================================================
+ Coverage   70.7201%   72.8471%   +2.1270%     
================================================
  Files          1473       1474         +1     
  Lines        437010     437844       +834     
================================================
+ Hits         309054     318957      +9903     
+ Misses       108583      98904      -9679     
- Partials      19373      19983       +610     
Flag Coverage Δ
integration 49.0651% <75.0000%> (?)
unit 70.5010% <0.0000%> (-0.0287%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4298% <ø> (+5.5318%) ⬆️

@zimulala
Copy link
Contributor Author

CI failed because of #51684

@ti-chi-bot ti-chi-bot bot merged commit 478ab1f into pingcap:master Mar 12, 2024
21 checks passed
@zimulala zimulala deleted the zimuxia/expr-err branch March 13, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the error message of the default value expression more appropriate.
3 participants