-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, tests: make the error message of the default value expression more appropriate. #51704
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@zimulala: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51704 +/- ##
================================================
+ Coverage 70.7201% 72.8471% +2.1270%
================================================
Files 1473 1474 +1
Lines 437010 437844 +834
================================================
+ Hits 309054 318957 +9903
+ Misses 108583 98904 -9679
- Partials 19373 19983 +610
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CI failed because of #51684 |
What problem does this PR solve?
Issue Number: close #51703
Problem Summary:
What changed and how does it work?
Now we support
REPLACE
as the default value expression, but don't supportREPLACE('xdfj-jfj', '-', ''))
.So tiny update the error message.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.