-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: code prepare for support OR list nested in AND list for mv index #51780
planner: code prepare for support OR list nested in AND list for mv index #51780
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51780 +/- ##
================================================
- Coverage 72.5274% 68.7737% -3.7537%
================================================
Files 1476 1476
Lines 364152 433645 +69493
================================================
+ Hits 264110 298234 +34124
- Misses 80658 115396 +34738
- Partials 19384 20015 +631
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eqOnNonMVColTp | ||
multiValuesOROnMVColTp | ||
multiValuesANDOnMVColTp | ||
singleValueOnMVColTp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add more comments on the situation they stands
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51778
Problem Summary:
Some code preparation to make #51716 smaller.
What changed and how does it work?
tests/integrationtest/r/planner/core/indexmerge_path.result
,tests/integrationtest/t/planner/core/indexmerge_path.test
)pkg/planner/core/indexmerge_path_test.go
)pkg/planner/core/indexmerge_path.go
)pkg/planner/core/indexmerge_path.go
)PrepareCols4MVIndex() -> PrepareIdxColsAndUncoverArrayType()
: Add a parameter to allow this function not to check there is exactly 1 virtual column. In the next PR, we'll use this function for the non-MV index.jsonArrayExpr2Exprs()
: Add a parameter to allow skipping the check for skipping plan cache. This will be used if we are not building an access path and are only doing checks and collecting information. This will be used in the next function.checkFilter4MVIndexColumn()
buildPartialPaths4MVIndex()
. Using these values, we also return the "type" of the access filter.collectFilters4MVIndex()
: Based on changes incheckFilter4MVIndexColumn()
, provide a "type" for the access filters in the return value.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.