Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Fix compact for VARCHAR PK (#51812) #51819

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51812

What problem does this PR solve?

Issue Number: Fix #51810

Problem Summary:

What changed and how does it work?

When returning the Start key and End key to TiDB, TiFlash does not encode them in a memory comparable way, so that we cannot simply compare these keys.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix `ALTER TABLE ... COMPACT` may not work for tables with a VARCHAR primary key

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 15, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@68ab772). Click here to learn what that means.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51819   +/-   ##
================================================
  Coverage               ?   71.9856%           
================================================
  Files                  ?       1408           
  Lines                  ?     409090           
  Branches               ?          0           
================================================
  Hits                   ?     294486           
  Misses                 ?      94788           
  Partials               ?      19816           
Flag Coverage Δ
unit 71.9856% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3457% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 16, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [breezewish,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2024
Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-16 02:38:26.09447457 +0000 UTC m=+1085133.116720958: ☑️ agreed by breezewish.
  • 2024-04-15 08:52:20.419699497 +0000 UTC m=+241759.530745941: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 6f93a7c into pingcap:release-7.5 Apr 15, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants