-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix compact for VARCHAR PK (#51812) #51819
executor: Fix compact for VARCHAR PK (#51812) #51819
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51819 +/- ##
================================================
Coverage ? 71.9856%
================================================
Files ? 1408
Lines ? 409090
Branches ? 0
================================================
Hits ? 294486
Misses ? 94788
Partials ? 19816
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51812
What problem does this PR solve?
Issue Number: Fix #51810
Problem Summary:
What changed and how does it work?
When returning the Start key and End key to TiDB, TiFlash does not encode them in a memory comparable way, so that we cannot simply compare these keys.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.