-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globalsort: split files evenly in MergeOverlappingFiles #51878
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51878 +/- ##
=================================================
- Coverage 70.6586% 54.6734% -15.9852%
=================================================
Files 1477 1588 +111
Lines 438466 608910 +170444
=================================================
+ Hits 309814 332912 +23098
- Misses 109184 252851 +143667
- Partials 19468 23147 +3679
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #50752
Problem Summary:
What changed and how does it work?
try to split files more evenly to improve performance
Check List
Tests
before(import 1.194TiB with force merge step)
after(about 2~3 minutes improvement)
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.