Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globalsort: split files evenly in MergeOverlappingFiles #51878

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 19, 2024

What problem does this PR solve?

Issue Number: ref #50752

Problem Summary:

What changed and how does it work?

try to split files more evenly to improve performance

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before(import 1.194TiB with force merge step)

[step=merge-sort] [mem-limit-percent=0.99] [server-mem-limit=88%] [resource="[CPU=16, Mem=27.83GiB]"] [takeTime=31m43.024898826s] []

after(about 2~3 minutes improvement)

[step=merge-sort] [mem-limit-percent=0.99] [server-mem-limit=88%] [resource="[CPU=16, Mem=27.83GiB]"] [takeTime=28m39.158921948s]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 19, 2024
@D3Hunter D3Hunter changed the title globalsort: opt split files in merge step [WIP]globalsort: opt split files in merge step Mar 19, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 19, 2024
Copy link

tiprow bot commented Mar 19, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #51878 (cf43e67) into master (7056209) will decrease coverage by 15.9852%.
Report is 7 commits behind head on master.
The diff coverage is 87.5000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51878         +/-   ##
=================================================
- Coverage   70.6586%   54.6734%   -15.9852%     
=================================================
  Files          1477       1588        +111     
  Lines        438466     608910     +170444     
=================================================
+ Hits         309814     332912      +23098     
- Misses       109184     252851     +143667     
- Partials      19468      23147       +3679     
Flag Coverage Δ
integration 36.6052% <70.8333%> (?)
unit 70.4527% <87.5000%> (+0.0038%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3332% <87.5000%> (+5.5249%) ⬆️

@D3Hunter D3Hunter changed the title [WIP]globalsort: opt split files in merge step [WIP]globalsort: split files evenly in merge overlapping files Mar 19, 2024
@D3Hunter D3Hunter changed the title [WIP]globalsort: split files evenly in merge overlapping files [WIP]globalsort: split files evenly in MergeOverlappingFiles Mar 19, 2024
@D3Hunter D3Hunter changed the title [WIP]globalsort: split files evenly in MergeOverlappingFiles globalsort: split files evenly in MergeOverlappingFiles Mar 19, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2024
@D3Hunter
Copy link
Contributor Author

@lance6716

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 19, 2024
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2024
Copy link

ti-chi-bot bot commented Mar 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-19 08:24:15.625247895 +0000 UTC m=+1365082.647494282: ☑️ agreed by lance6716.
  • 2024-03-19 08:41:03.432294614 +0000 UTC m=+1366090.454541001: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 61c4714 into pingcap:master Mar 19, 2024
29 of 33 checks passed
@D3Hunter D3Hunter deleted the opt-split-files branch March 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants