Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk_snap_restore: remove checking store number #51886

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 19, 2024

warn if store num not match

What problem does this PR solve?

Issue Number: close #51957

Problem Summary:
It is unnecessary to check the store number in data restore phase -- since tidb-operator will help us to check it.
Now this check breaks a workaround for one store cannot unexpectedly bootstrap after restoring.

What changed and how does it work?

This PR removes the check to number of stores.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    The change is tiny and I manually tested it in a local k8s cluster.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yu Juncen <yu745514916@live.com>

warn if store num not match

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
Copy link

tiprow bot commented Mar 19, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #51886 (d95c817) into master (9b6db9d) will decrease coverage by 15.6434%.
Report is 19 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51886         +/-   ##
=================================================
- Coverage   70.7435%   55.1002%   -15.6434%     
=================================================
  Files          1477       1588        +111     
  Lines        438550     611885     +173335     
=================================================
+ Hits         310246     337150      +26904     
- Misses       108884     251593     +142709     
- Partials      19420      23142       +3722     
Flag Coverage Δ
integration 37.0396% <0.0000%> (?)
unit 70.8730% <0.0000%> (+0.3299%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.6862% <0.0000%> (+5.8577%) ⬆️

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Mar 20, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 10:12:15.39573995 +0000 UTC m=+1457962.417986338: ☑️ agreed by BornChanger.
  • 2024-03-20 11:16:38.695656491 +0000 UTC m=+1461825.717902878: ☑️ agreed by 3pointer.

@BornChanger
Copy link
Contributor

BornChanger commented Mar 20, 2024

/type cherry-pick-for-release-6.5

Copy link

ti-chi-bot bot commented Mar 20, 2024

@BornChanger: The label(s) type/needs-cherry-pick-release-6.5 cannot be applied, because the repository doesn't have them.

In response to this:

/type needs-cherry-pick-release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Mar 20, 2024
Copy link

tiprow bot commented Mar 20, 2024

@YuJuncen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow d95c817 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YuJuncen
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Mar 20, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 274d5e2 into pingcap:master Mar 20, 2024
35 of 47 checks passed
@YuJuncen YuJuncen added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 20, 2024
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51961.

@YuJuncen YuJuncen changed the title log_backup: remove checking store number disk_snap_backup: remove checking store number Apr 3, 2024
@YuJuncen YuJuncen changed the title disk_snap_backup: remove checking store number disk_snap_restore: remove checking store number Apr 3, 2024
@BornChanger BornChanger added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Apr 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52562.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52563.

YuJuncen added a commit to YuJuncen/tidb that referenced this pull request May 6, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 6, 2024
…) (pingcap#48) (pingcap#62)

close pingcap#51957

Co-authored-by: Naman Gupta <naman.gupta@airbnb.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
…) (pingcap#48)

close pingcap#51957

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs_br: BR should not check whether upstream and downstream contains different node
4 participants