-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk_snap_restore: remove checking store number #51886
Conversation
Signed-off-by: Yu Juncen <yu745514916@live.com> warn if store num not match Signed-off-by: Yu Juncen <yu745514916@live.com>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51886 +/- ##
=================================================
- Coverage 70.7435% 55.1002% -15.6434%
=================================================
Files 1477 1588 +111
Lines 438550 611885 +173335
=================================================
+ Hits 310246 337150 +26904
- Misses 108884 251593 +142709
- Partials 19420 23142 +3722
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/type cherry-pick-for-release-6.5 |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@YuJuncen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…) (pingcap#48) (pingcap#62) close pingcap#51957 Co-authored-by: Naman Gupta <naman.gupta@airbnb.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
…) (pingcap#48) close pingcap#51957 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
warn if store num not match
What problem does this PR solve?
Issue Number: close #51957
Problem Summary:
It is unnecessary to check the store number in data restore phase -- since tidb-operator will help us to check it.
Now this check breaks a workaround for one store cannot unexpectedly bootstrap after restoring.
What changed and how does it work?
This PR removes the check to number of stores.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.