-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Change default check point lag limit #51906
br: Change default check point lag limit #51906
Conversation
Hi @BornChanger. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51906 +/- ##
=================================================
- Coverage 70.6676% 54.5805% -16.0871%
=================================================
Files 1481 1592 +111
Lines 439252 608909 +169657
=================================================
+ Hits 310409 332346 +21937
- Misses 109334 253347 +144013
- Partials 19509 23216 +3707
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5c9064b
to
b6abadd
Compare
@BornChanger: GitHub didn't allow me to request PR reviews from the following users: RidRisR. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. |
@BornChanger: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
ebbbabd
to
fe7a656
Compare
/type cherry-pick-for-release-8.0 |
@BornChanger: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/type cherry-pick-for-release-6.5 |
/type cherry-pick-for-release-7.1 |
/type cherry-pick-for-release-7.5 |
/remove-type cherry-pick-for-release-8.0 |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #50803
Problem Summary:
What changed and how does it work?
This PR set the default value of 'check-point-lag-limit' to 24 hours, and also expose the paramter.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.