Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema_v2: fix TestPartitionAddIndexGC #52163

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 27, 2024

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
diff --git a/pkg/sessionctx/variable/tidb_vars.go b/pkg/sessionctx/variable/tidb_vars.go
index d5e9b34324..73e6f48387 100644
--- a/pkg/sessionctx/variable/tidb_vars.go
+++ b/pkg/sessionctx/variable/tidb_vars.go
@@ -1483,7 +1483,7 @@ const (
        DefTiDBSchemaVersionCacheLimit                    = 16
        DefTiDBIdleTransactionTimeout                     = 0
        DefTiDBTxnEntrySizeLimit                          = 0
-       DefTiDBSchemaCacheSize                            = 0
+       DefTiDBSchemaCacheSize                            = 1024
        DefTiDBLowResolutionTSOUpdateInterval             = 2000
make ut X='run pkg/ddl/test/fail/ddl_test TestPartitionAddIndexGC'
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2024
Copy link

tiprow bot commented Mar 27, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #52163 (bf3bfb9) into master (dde0a54) will decrease coverage by 16.8805%.
Report is 42 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52163         +/-   ##
=================================================
- Coverage   70.7222%   53.8417%   -16.8805%     
=================================================
  Files          1489       1679        +190     
  Lines        439999     636333     +196334     
=================================================
+ Hits         311177     342613      +31436     
- Misses       109329     269956     +160627     
- Partials      19493      23764       +4271     
Flag Coverage Δ
integration 36.6650% <0.0000%> (?)
unit 70.4524% <100.0000%> (-0.0874%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5182% <ø> (+4.6663%) ⬆️

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 02:31:06.766692619 +0000 UTC m=+2121493.788939001: ☑️ agreed by ywqzzy.
  • 2024-04-02 02:24:42.828505027 +0000 UTC m=+324344.356045568: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit c1344e1 into pingcap:master Apr 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants