Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: don't display tables in MemDB when query TIDB_HOT_REGIONS #52180

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50810

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Create a cluster by tiup playground nightly --db 1 --tiflash 0 --without-monitor and wait a minutes.

Before this patch sometimes the query result will like

mysql> select * from `TIDB_HOT_REGIONS`;
+---------------------+----------+--------------------+------------------+------------+-----------+------+----------------+--------------+------------+
| TABLE_ID            | INDEX_ID | DB_NAME            | TABLE_NAME       | INDEX_NAME | REGION_ID | TYPE | MAX_HOT_DEGREE | REGION_COUNT | FLOW_BYTES |
+---------------------+----------+--------------------+------------------+------------+-----------+------+----------------+--------------+------------+
| 4611686018427387961 |     NULL | INFORMATION_SCHEMA | INSPECTION_RULES | NULL       |        56 | read |             37 |            0 |      30600 |
+---------------------+----------+--------------------+------------------+------------+-----------+------+----------------+--------------+------------+
1 row in set (0.00 sec)

After patch, only get tidb_ddl_job table

mysql> select * from `TIDB_HOT_REGIONS`;
+-----------------+----------+---------+--------------+------------+-----------+------+----------------+--------------+------------+
| TABLE_ID        | INDEX_ID | DB_NAME | TABLE_NAME   | INDEX_NAME | REGION_ID | TYPE | MAX_HOT_DEGREE | REGION_COUNT | FLOW_BYTES |
+-----------------+----------+---------+--------------+------------+-----------+------+----------------+--------------+------------+
| 281474976710654 |     NULL | mysql   | tidb_ddl_job | NULL       |        56 | read |             38 |            0 |      30600 |
+-----------------+----------+---------+--------------+------------+-----------+------+----------------+--------------+------------+
1 row in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2024
Copy link

tiprow bot commented Mar 28, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 requested a review from xhebox March 28, 2024 06:28
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2024
@Defined2014 Defined2014 requested a review from ywqzzy March 28, 2024 06:39
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 28, 2024
@Defined2014 Defined2014 added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #52180 (e44b0ee) into master (b942197) will decrease coverage by 17.6314%.
Report is 18 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52180         +/-   ##
=================================================
- Coverage   72.4092%   54.7779%   -17.6314%     
=================================================
  Files          1487       1601        +114     
  Lines        365652     610664     +245012     
=================================================
+ Hits         264766     334509      +69743     
- Misses        81332     252917     +171585     
- Partials      19554      23238       +3684     
Flag Coverage Δ
integration 36.8867% <0.0000%> (?)
unit 70.5045% <0.0000%> (-1.7971%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.6674% <ø> (+5.3381%) ⬆️

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 07:05:59.607164387 +0000 UTC m=+2137986.629410786: ☑️ agreed by ywqzzy.
  • 2024-03-28 07:27:29.257144325 +0000 UTC m=+2139276.279390708: ☑️ agreed by xhebox.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit f58f5e1 into pingcap:master Mar 28, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52204.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52205.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52206.

@Defined2014 Defined2014 deleted the fix-50810 branch March 28, 2024 11:29
Defined2014 added a commit to ti-chi-bot/tidb that referenced this pull request May 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query TIDB_HOT_REGIONS return some unexpected result
4 participants