statistics: shard needsStatsMap #52183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52183 +/- ##
================================================
+ Coverage 69.2555% 72.6682% +3.4127%
================================================
Files 1490 1490
Lines 420134 440202 +20068
================================================
+ Hits 290966 319887 +28921
+ Misses 109658 100114 -9544
- Partials 19510 20201 +691
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
AilinKid
reviewed
Mar 28, 2024
pkg/statistics/table.go
Outdated
| } | ||
|
|
||
| func getIdx(tbl model.TableItemID) int64 { | ||
| result := tbl.ID % shardCnt |
There was a problem hiding this comment.
you can just tbl.ID's negativeness before mod
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/retest |
winoros
approved these changes
Mar 28, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
AilinKid
approved these changes
Mar 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #51853
Problem Summary:
What changed and how does it work?
there is a global lock, and although there are plenty of write/read paths, by sharding, I can increase the granularity of the locks.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.