Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix the error msg in default_as_expession #52268

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Apr 1, 2024

What problem does this PR solve?

Issue Number: close #52267

Problem Summary:

What changed and how does it work?

run test [ddl/default_as_expression] err: sql:alter table t0 modify column c1 datetime DEFAULT (date_format(now(), '%Y-%m-%d'));: failed to run query
\"alter table t0 modify column c1 datetime DEFAULT (date_format(now(), '%Y-%m-%d'));\"
 around line 58,
we need(139):
alter table t0 modify column c1 datetime DEFAULT (date_format(now(), '%Y-%m-%d'));
Error 1292 (22007): Incorrect datetime value: '2024-03'

but got(139):
alter table t0 modify column c1 datetime DEFAULT (date_format(now(), '%Y-%m-%d'));
Error 1292 (22007): Incorrect datetime value: '2024-04'

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2024
Copy link

tiprow bot commented Apr 1, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 02:41:01.085696647 +0000 UTC m=+238922.613237186: ☑️ agreed by Defined2014.
  • 2024-04-01 02:41:07.318140446 +0000 UTC m=+238928.845680986: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 42673cb into pingcap:master Apr 1, 2024
12 checks passed
@zimulala zimulala deleted the zimuxia/fix-test branch April 1, 2024 04:10
imalasong pushed a commit to imalasong/tidb that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_as_expession is failed because of the wrong error msg
3 participants