Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix flaky slot manager test #52271

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 1, 2024

What problem does this PR solve?

Issue Number: close #52252

Problem Summary:

What changed and how does it work?

Make sure mock close is registered

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2024
Copy link

tiprow bot commented Apr 1, 2024

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 1, 2024

/check-issue-triage-complete

1 similar comment
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 1, 2024

/check-issue-triage-complete

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 04:03:27.506298542 +0000 UTC m=+243869.033839088: ☑️ agreed by hawkingrei.
  • 2024-04-02 01:45:55.751016991 +0000 UTC m=+322017.278557537: ☑️ agreed by zimulala.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #52271 (0f51d5d) into master (b1c0e36) will increase coverage by 1.9103%.
Report is 29 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52271        +/-   ##
================================================
+ Coverage   70.6738%   72.5842%   +1.9103%     
================================================
  Files          1491       1496         +5     
  Lines        440116     443376      +3260     
================================================
+ Hits         311047     321821     +10774     
+ Misses       109532     101322      -8210     
- Partials      19537      20233       +696     
Flag Coverage Δ
integration 48.8680% <ø> (?)
unit 70.4573% <ø> (-0.0254%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3134% <ø> (+4.5133%) ⬆️

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 2, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, okJiang, ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 27e470a into pingcap:master Apr 2, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestSlotManagerInManager
4 participants