-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask: fix flaky slot manager test #52271
Conversation
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-issue-triage-complete |
1 similar comment
/check-issue-triage-complete |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52271 +/- ##
================================================
+ Coverage 70.6738% 72.5842% +1.9103%
================================================
Files 1491 1496 +5
Lines 440116 443376 +3260
================================================
+ Hits 311047 321821 +10774
+ Misses 109532 101322 -8210
- Partials 19537 20233 +696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, okJiang, ywqzzy, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #52252
Problem Summary:
What changed and how does it work?
Make sure mock close is registered
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.