Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix wrong singleflight implementation for stats' syncload (#52301) #52382

Merged
merged 6 commits into from
Aug 27, 2024
Merged

statistics: fix wrong singleflight implementation for stats' syncload (#52301) #52382

merged 6 commits into from
Aug 27, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52301

What problem does this PR solve?

Issue Number: close #52294

Problem Summary:

What changed and how does it work?

the problem has been described in the issue. we refactor the singleflight using the golang official library.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 7, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-52301-to-release-7.1 branch from f47dca6 to 7ebc335 Compare April 7, 2024 08:45
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2024
@hawkingrei hawkingrei force-pushed the cherry-pick-52301-to-release-7.1 branch from dcbfae3 to 4ba0068 Compare April 17, 2024 03:32
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 18, 2024
@hawkingrei hawkingrei closed this Apr 18, 2024
@hawkingrei hawkingrei reopened this Apr 23, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 27, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 06:40:06.510201896 +0000 UTC m=+852401.644652019: ☑️ agreed by hawkingrei.
  • 2024-08-27 06:41:36.231620432 +0000 UTC m=+852491.366070554: ☑️ agreed by winoros.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@hawkingrei
This is an automated cherry-pick of pingcap#52301
0821927 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei
update
11acaad 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6884642 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
e4516f8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
ba091a4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the cherry-pick-52301-to-release-7.1 branch from 32929bc to ba091a4 Compare August 27, 2024 06:59
@hawkingrei
Copy link
Member

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@winoros
Copy link
Member

winoros commented Aug 27, 2024

/retest

@hawkingrei
update
3a80ba0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@e0cf097). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #52382   +/-   ##
================================================
  Coverage               ?   73.4720%           
================================================
  Files                  ?       1211           
  Lines                  ?     380418           
  Branches               ?          0           
================================================
  Hits                   ?     279501           
  Misses                 ?      83071           
  Partials               ?      17846

@ti-chi-bot ti-chi-bot bot merged commit 268a1e8 into pingcap:release-7.1 Aug 27, 2024
12 checks passed
winoros pushed a commit to winoros/tidb that referenced this pull request Aug 28, 2024
@ti-chi-bot @winoros
statistics: fix wrong singleflight implementation for stats' syncload (…
cda3138 
…pingcap#52301) (pingcap#52382)

close pingcap#52294
@winoros winoros mentioned this pull request Aug 28, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@winoros
statistics: fix wrong singleflight implementation for stats' syncload(#…
0002c1a 
…52301) (#52382) (#55726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

@hawkingrei hawkingrei

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @hawkingrei @winoros