Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: update dependency pebbledb to v1.1.0 #52400

Merged
merged 15 commits into from
Apr 10, 2024

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Apr 8, 2024

What problem does this PR solve?

Update dependency pebbledb to v1.1.0.

Issue Number: close #52402

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    Only a dependency is updated.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2024
Copy link

tiprow bot commented Apr 8, 2024

Hi @hicqu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hicqu
Copy link
Contributor Author

hicqu commented Apr 8, 2024

/retest

Copy link

tiprow bot commented Apr 8, 2024

@hicqu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Apr 8, 2024

/retest

Copy link

tiprow bot commented Apr 8, 2024

@hicqu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52400 (2cf48f2) into master (fa9761f) will increase coverage by 3.8831%.
Report is 29 commits behind head on master.
The diff coverage is 63.7681%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52400        +/-   ##
================================================
+ Coverage   70.6127%   74.4959%   +3.8831%     
================================================
  Files          1467       1489        +22     
  Lines        408378     442000     +33622     
================================================
+ Hits         288367     329272     +40905     
+ Misses       100800      92144      -8656     
- Partials      19211      20584      +1373     
Flag Coverage Δ
integration 50.5685% <55.5555%> (?)
unit 71.1576% <60.8695%> (+1.7153%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 48.0150% <ø> (+5.5649%) ⬆️

hicqu added 7 commits April 8, 2024 16:05
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Apr 8, 2024

/retest

Copy link

tiprow bot commented Apr 8, 2024

@hicqu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 07:06:57.088836498 +0000 UTC m=+859678.616377039: ☑️ agreed by 3pointer.
  • 2024-04-09 06:21:35.219587156 +0000 UTC m=+943356.747127701: ☑️ agreed by hawkingrei.

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Apr 10, 2024

/test pull-lightning-integration-test

@pingcap pingcap deleted a comment from tiprow bot Apr 10, 2024
@pingcap pingcap deleted a comment from tiprow bot Apr 10, 2024
hicqu added 2 commits April 10, 2024 12:50
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Copy link

ti-chi-bot bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, D3Hunter, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Apr 10, 2024

/test unit-test

Copy link

tiprow bot commented Apr 10, 2024

@hicqu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hicqu
Copy link
Contributor Author

hicqu commented Apr 10, 2024

/test pull-mysql-client-test

Copy link

tiprow bot commented Apr 10, 2024

@hicqu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@wuhuizuo
Copy link
Contributor

/hold

GraphQL: Merge already in progress (mergePullRequest)

broken by https://www.githubstatus.com/incidents/k7bc8pkxpmbp

@wuhuizuo
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2b6b78a into pingcap:master Apr 10, 2024
22 checks passed
@hicqu hicqu deleted the update-pebble-db branch April 10, 2024 10:42
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request Apr 16, 2024
lance6716 pushed a commit to lance6716/tidb that referenced this pull request Aug 1, 2024
close pingcap#52402

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55128.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 1, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency pebbledb to an official release version
6 participants