-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Move more methods from SessionVars
to BuildContext
#52440
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52440 +/- ##
================================================
+ Coverage 72.1392% 74.3858% +2.2466%
================================================
Files 1467 1467
Lines 426844 427120 +276
================================================
+ Hits 307922 317717 +9795
+ Misses 99686 89605 -10081
- Partials 19236 19798 +562
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #52366
What changed and how does it work?
Added more methods in
expression.BuildContext
AllocPlanColumnID
to allocate column id for Column expression.SetInUnionCast
/IsInUnionCast
is used when building expressions in union cast.SetInNullRejectCheck
/IsInNullRejectCheck
is used for bull reject check when building plan.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.