Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: make sure put key into ETCD monotonously (#52381) #52481

Merged
merged 8 commits into from
Jun 5, 2024
Merged

ddl: make sure put key into ETCD monotonously (#52381) #52481

merged 8 commits into from
Jun 5, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52381

What problem does this PR solve?

Issue Number: close #47060 and close #52335

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

wjhuang2016 and others added 6 commits April 10, 2024 10:55
@wjhuang2016 @ti-chi-bot
done
05e3d72 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 @tangenta @ti-chi-bot
Update pkg/ddl/util/util.go
5727dfc 
Co-authored-by: tangenta <tangenta@126.com>
@wjhuang2016 @tangenta @ti-chi-bot
Update pkg/ddl/util/util.go
a2923ec 
Co-authored-by: tangenta <tangenta@126.com>
@wjhuang2016 @ti-chi-bot
add test
32b861b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 @ti-chi-bot
refine
42d263a 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 @ti-chi-bot
fix
b15b141 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 10, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2024
Merged
13 tasks
Benjamin2037
Benjamin2037 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 10, 2024
@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-10 10:56:51.748452755 +0000 UTC m=+1046273.275993301: ☑️ agreed by Benjamin2037.
  • 2024-06-03 02:22:59.687804047 +0000 UTC m=+3261533.444939621: ☑️ agreed by lance6716.

@lance6716
fix CI
6019293 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2024
@wjhuang2016
Copy link
Member

/retest

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@9815b45). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #52481   +/-   ##
================================================
  Coverage               ?   73.6824%           
================================================
  Files                  ?       1096           
  Lines                  ?     351815           
  Branches               ?          0           
================================================
  Hits                   ?     259226           
  Misses                 ?      75952           
  Partials               ?      16637

@ti-chi-bot ti-chi-bot bot merged commit 60e6e0b into pingcap:release-6.5 Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees

@wjhuang2016 wjhuang2016

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lance6716 @wjhuang2016 @Benjamin2037