Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix adding multi-value index (#51884) #52498

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51884

What problem does this PR solve?

Issue Number: close #51162

Problem Summary:

What changed and how does it work?

Restored data should not truncated in buildHandle.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2024
13 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
@ywqzzy ywqzzy removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
@ywqzzy ywqzzy force-pushed the cherry-pick-51884-to-release-7.1 branch from 1d498a4 to ad91214 Compare April 17, 2024 10:13
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 10:14:32.277000004 +0000 UTC m=+419491.388046454: ☑️ agreed by ywqzzy.
  • 2024-04-17 10:19:07.334835807 +0000 UTC m=+419766.445882256: ☑️ agreed by D3Hunter.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@e904a8c). Click here to learn what that means.
The diff coverage is 21.4285%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #52498   +/-   ##
================================================
  Coverage               ?   73.4328%           
================================================
  Files                  ?       1211           
  Lines                  ?     379950           
  Branches               ?          0           
================================================
  Hits                   ?     279008           
  Misses                 ?      83121           
  Partials               ?      17821           

@ti-chi-bot ti-chi-bot bot merged commit d42a2ab into pingcap:release-7.1 Apr 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants