-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make tablesample work under different partition prune modes (#52405) #52546
executor: make tablesample work under different partition prune modes (#52405) #52546
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52546 +/- ##
================================================
Coverage ? 72.3526%
================================================
Files ? 1467
Lines ? 427618
Branches ? 0
================================================
Hits ? 309393
Misses ? 98949
Partials ? 19276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52405
What problem does this PR solve?
Issue Number: close #52282
Problem Summary:
When
tidb_partition_prune_mode
isstatic
, TiDB uses a separate operator to union results from different partitions. Buttablesample
always collects samples from all partitions, the result may contains duplicated rows.What changed and how does it work?
Pass
physicalTableID
toTableSampleExecutor
, now it only collect samples from corresponding partitions.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.