Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make tablesample work under different partition prune modes (#52405) #52546

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52405

What problem does this PR solve?

Issue Number: close #52282

Problem Summary:

When tidb_partition_prune_mode is static, TiDB uses a separate operator to union results from different partitions. But tablesample always collects samples from all partitions, the result may contains duplicated rows.

What changed and how does it work?

Pass physicalTableID to TableSampleExecutor, now it only collect samples from corresponding partitions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@f471b0b). Click here to learn what that means.
The diff coverage is 55.5555%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52546   +/-   ##
================================================
  Coverage               ?   72.3526%           
================================================
  Files                  ?       1467           
  Lines                  ?     427618           
  Branches               ?          0           
================================================
  Hits                   ?     309393           
  Misses                 ?      98949           
  Partials               ?      19276           
Flag Coverage Δ
unit 71.2328% <55.5555%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.1198% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/cherry-pick-not-approved labels Apr 15, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 07:42:21.055775056 +0000 UTC m=+237560.166821506: ☑️ agreed by Defined2014.
  • 2024-04-16 07:33:12.629412872 +0000 UTC m=+323411.740459324: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 0ed2e16 into pingcap:release-8.1 Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants