-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Enable checkpoint advancer to pause tasks lagged too large (#51441) #52555
br: Enable checkpoint advancer to pause tasks lagged too large (#51441) #52555
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #52555 +/- ##
================================================
Coverage ? 72.1045%
================================================
Files ? 1412
Lines ? 411505
Branches ? 0
================================================
Hits ? 296714
Misses ? 94879
Partials ? 19912
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/test unit-test |
@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@YuJuncen: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #51441
What problem does this PR solve?
Issue Number: close #50803
Problem Summary:
What changed and how does it work?
Now, a new option called
CheckPointLagLimit
is added to the advancer config. When it is set, advancer will check if the checkpoint is lagged too large on every tick. If so, advancer would send a warning to PD and unstall the task.PS: Theoretically, we need a resume signal when the task could be resumed. However, there is no channel to send this signal now. Maybe we will add it in the future.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.