server: schema info api of http status server #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMouche
reviewed
Nov 29, 2017
server/region_handler.go
Outdated
| // table schema of a specified table name | ||
| cTableName := model.NewCIStr(tableName) | ||
| if data, err := schema.TableByName(cDBName, cTableName); err != nil { | ||
| rh.writeError(w, err) |
There was a problem hiding this comment.
Could we return after writeXXX, since we do not care about this logic anymore?
|
/run-all-tests |
shenli
reviewed
Nov 29, 2017
server/region_handler.go
Outdated
| } | ||
| rh.writeError(w, infoschema.ErrDatabaseNotExists.GenByArgs(dbName)) | ||
| return | ||
| } else if tableID := req.FormValue(pTableID); len(tableID) > 0 { |
There was a problem hiding this comment.
WIth the return in line 266, we do not need the else. So as line 280.
zimulala
reviewed
Nov 30, 2017
server/region_handler_test.go
Outdated
| err = decoder.Decode(&t) | ||
| c.Assert(err, IsNil) | ||
|
|
||
| resp, err = http.Get(fmt.Sprintf("http://127.0.0.1:10090/schema?table_id=a")) |
There was a problem hiding this comment.
If we don't check resp, using _ is better.
server/region_handler.go
Outdated
| pRegionID = "regionID" | ||
| pRecordID = "recordID" | ||
| pStartTS = "startTS" | ||
| pHexKey = "hexKey" | ||
| pTableID = "table_id" |
There was a problem hiding this comment.
Should we need to use the unified format? tableID or region_id
There was a problem hiding this comment.
It's based on @AndreMouche 's document. I'll check it out.
There was a problem hiding this comment.
Has moved it to a standalone part.
tiancaiamao
reviewed
Nov 30, 2017
| decoder := json.NewDecoder(resp.Body) | ||
| var dbs []*model.DBInfo | ||
| err = decoder.Decode(&dbs) | ||
| c.Assert(err, IsNil) |
server/region_handler_test.go
Outdated
| var t *tables.MemoryTable | ||
| decoder = json.NewDecoder(resp.Body) | ||
| err = decoder.Decode(&t) | ||
| c.Assert(err, IsNil) |
|
/run-all-tests |
|
LGTM |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Jan 12, 2018
ngaut
pushed a commit
that referenced
this pull request
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @AndreMouche