Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix flaky test #52573

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Apr 12, 2024

What problem does this PR solve?

Issue Number: close #52547

Problem Summary:
the flaky test TestGetTSWithRetry takes too much time.

What changed and how does it work?

less retry

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth added 2 commits April 12, 2024 16:59
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2024
Copy link

tiprow bot commented Apr 12, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Merging #52573 (dd64756) into master (312b69f) will increase coverage by 3.7913%.
Report is 50 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52573        +/-   ##
================================================
+ Coverage   72.2371%   76.0285%   +3.7913%     
================================================
  Files          1467       1476         +9     
  Lines        426991     444503     +17512     
================================================
+ Hits         308446     337949     +29503     
+ Misses        99430      86061     -13369     
- Partials      19115      20493      +1378     
Flag Coverage Δ
integration 51.6133% <0.0000%> (?)
unit 72.1552% <100.0000%> (+1.0268%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 59.3028% <100.0000%> (+18.1774%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 12, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 10:10:58.489000361 +0000 UTC m=+1216320.016540907: ☑️ agreed by hawkingrei.
  • 2024-04-17 05:57:41.410171161 +0000 UTC m=+404080.521217611: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit b4c8749 into pingcap:master Apr 17, 2024
36 of 39 checks passed
@Leavrth Leavrth added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Apr 17, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #52665.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2024
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52666.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52667.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52668.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2024
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 17, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 7, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 22, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGetTSWithRetry take too much time
4 participants