-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add integration test for ingest corner case test #52734
br: add integration test for ingest corner case test #52734
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52734 +/- ##
================================================
+ Coverage 72.3230% 75.0486% +2.7256%
================================================
Files 1471 1473 +2
Lines 427219 427745 +526
================================================
+ Hits 308978 321017 +12039
+ Misses 98951 86477 -12474
- Partials 19290 20251 +961
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Since pingcap/tidb#52734, we need to use failpoint tidb-server for br integration test Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
/cc @Benjamin2037 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, BornChanger, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Since pingcap/tidb#52734, we need to use failpoint tidb-server for br integration test
Since pingcap/tidb#52734, we need to use failpoint tidb-server for br integration test
What problem does this PR solve?
Issue Number: close #52733
Problem Summary:
When creating index, log backup should be able to start.
What changed and how does it work?
remove the check, and add integration test.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.