expression: JSON_SCHEMA_VALID()

[dveeden]

What problem does this PR solve?

Issue Number: close #52779

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support for the `JSON_SCHEMA_VALID()` function was added.

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

/check-issue-triage-complete

[dveeden]

mysql> SELECT JSON_SCHEMA_VALID('{"required": ["a","b"]}', '{"a": 5,"c": 6}');
+-----------------------------------------------------------------+
| JSON_SCHEMA_VALID('{"required": ["a","b"]}', '{"a": 5,"c": 6}') |
+-----------------------------------------------------------------+
|                                                               0 |
+-----------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> SELECT JSON_SCHEMA_VALID('{"required": ["a","b"]}', '{"a": 5,"b": 6}');
+-----------------------------------------------------------------+
| JSON_SCHEMA_VALID('{"required": ["a","b"]}', '{"a": 5,"b": 6}') |
+-----------------------------------------------------------------+
|                                                               1 |
+-----------------------------------------------------------------+
1 row in set (0.00 sec)

[codecov]

Codecov Report

Attention: Patch coverage is 52.85714% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 74.6520%. Comparing base (4a51974) to head (d87f556).
Report is 29 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52780        +/-   ##
================================================
+ Coverage   70.8824%   74.6520%   +3.7696%     
================================================
  Files          1506       1506                
  Lines        412222     437594     +25372     
================================================
+ Hits         292193     326673     +34480     
+ Misses       100640      90912      -9728     
- Partials      19389      20009       +620     

Flag	Coverage Δ
integration	50.2067% <44.2857%> (?)
unit	71.4131% <47.1428%> (+1.6020%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	50.2588% <ø> (+6.7060%)	⬆️

[dveeden]

MySQL:

mysql> CREATE TABLE t (id INT PRIMARY KEY AUTO_INCREMENT, j JSON, CHECK(JSON_SCHEMA_VALID('{"type": "array"}', j)));
Query OK, 0 rows affected (0.01 sec)

mysql> INSERT INTO t VALUES (1, '[0,1,2,3,4]');
Query OK, 1 row affected (0.01 sec)

mysql> INSERT INTO t VALUES (1, '{}');
ERROR 3819 (HY000): Check constraint 't_chk_1' is violated.

TiDB:

mysql> SET GLOBAL tidb_enable_check_constraint=ON;
Query OK, 0 rows affected (0.00 sec)

mysql> CREATE TABLE t (id INT PRIMARY KEY AUTO_INCREMENT, j JSON, CHECK(JSON_SCHEMA_VALID('{"type": "array"}', j)));
ERROR 3812 (HY000): An expression of non-boolean type specified to a check constraint 't_chk_1'.

Update: Already fixed

[hawkingrei]

/ok-to-test

[dveeden]

/retest

[windtalker]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-30 10:40:52.260844455 +0000 UTC m=+353806.017980028: ☑️ agreed by hicqu.
• 2024-05-31 05:54:33.477724917 +0000 UTC m=+3015027.234860490: ☑️ agreed by windtalker.

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, hicqu, tangenta, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei,hicqu,tangenta,windtalker]
• pkg/expression/OWNERS [windtalker]
• pkg/parser/OWNERS [tangenta]
• pkg/planner/OWNERS [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment