Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: handle region leader miss (#52822) #52856

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52822

What problem does this PR solve?

Issue Number: close #51124 close #50501

Problem Summary:
the leader of region, scanned from PD, is nil

What changed and how does it work?

check regions' leader after scan from PD.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 24, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 24, 2024
13 tasks
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@4546180). Click here to learn what that means.
The diff coverage is 50.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52856   +/-   ##
================================================
  Coverage               ?   72.2715%           
================================================
  Files                  ?       1468           
  Lines                  ?     426973           
  Branches               ?          0           
================================================
  Hits                   ?     308580           
  Misses                 ?      99101           
  Partials               ?      19292           
Flag Coverage Δ
unit 71.1416% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.1218% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 24, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Apr 24, 2024

/retest

Copy link

ti-chi-bot bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 24, 2024
Copy link

ti-chi-bot bot commented Apr 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-24 08:01:02.484070593 +0000 UTC m=+160819.223973505: ☑️ agreed by lance6716.
  • 2024-04-24 08:16:19.284066417 +0000 UTC m=+161736.023969324: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit e8b2984 into pingcap:release-8.1 Apr 24, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants